![Aaron Marcher](/assets/img/avatar_default.png)
- Use block for single statement ifs - Keep lines to reasonable length (current debate as to reasonable) - When functions return -1 for error test against 0 not -1 - Do not indent cases another level - Do not test against NULL and 0 explicitly - Use tabs for indentation, use spaces for alignment
28 lines
479 B
C
28 lines
479 B
C
/* See LICENSE file for copyright and license details. */
|
|
#include <errno.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
|
|
#include "../util.h"
|
|
|
|
const char *
|
|
run_command(const char *cmd)
|
|
{
|
|
char *p;
|
|
FILE *fp;
|
|
|
|
if (!(fp = popen(cmd, "r"))) {
|
|
fprintf(stderr, "popen '%s': %s\n", cmd, strerror(errno));
|
|
return NULL;
|
|
}
|
|
p = fgets(buf, sizeof(buf) - 1, fp);
|
|
pclose(fp);
|
|
if (!p) {
|
|
return NULL;
|
|
}
|
|
if ((p = strrchr(buf, '\n'))) {
|
|
p[0] = '\0';
|
|
}
|
|
|
|
return buf[0] ? buf : NULL;
|
|
}
|