lhark/slstatus
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

On success, fgets always terminates the result.

Browse source 
If fgets succeeds, then the resulting char array is always
terminated by a '\0'. No need to keep extra space, therefore
sizeof(buf) is the correct argument.

Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
This commit is contained in:
Tobias Stoeckmann 2017-04-04 21:27:31 +02:00
parent 1289bdb742
commit 35295f1902
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
slstatus.c
View file

@ -447,7 +447,7 @@ run_command(const char *cmd)
warn("Failed to get command output for %s", cmd); warn("Failed to get command output for %s", cmd);
return smprintf("%s", UNKNOWN_STR); return smprintf("%s", UNKNOWN_STR);
} }
fgets(buf, sizeof(buf) - 1, fp); fgets(buf, sizeof(buf), fp);
pclose(fp); pclose(fp);
buf[sizeof(buf) - 1] = '\0'; buf[sizeof(buf) - 1] = '\0';